Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Ship .vst3 plugin as well as installer #211

Closed
glenclayton opened this issue Apr 18, 2023 · 4 comments
Closed

[FEATURE] Ship .vst3 plugin as well as installer #211

glenclayton opened this issue Apr 18, 2023 · 4 comments
Labels
enhancement New feature or request priority:low Low priority issues wontdo This will not be worked on

Comments

@glenclayton
Copy link

Since you must already build it can you also include the .vst3 file in the release zip so we can copy it directly rather than have to use the installer exe ?

@glenclayton glenclayton added enhancement New feature or request priority:low Low priority issues unread This issue is new and hasn't been seen by the maintainers yet urgent:no labels Apr 18, 2023
@sdatkinson sdatkinson removed the unread This issue is new and hasn't been seen by the maintainers yet label Apr 21, 2023
@sdatkinson
Copy link
Owner

Can you help me understand why you'd want this?

A workaround right now would be to build from source; does that work for you?

@dr-chase-g3ka1
Copy link

@sdatkinson
First of all, thank you for your hard work. NAM works and it's amazing.
This issue would be convenience improvement, because different apps lookup different paths for VST-s and sometimes people have to copy from the install destination.
Also not everyone needs the stand alone app, only the VST.
An easier work around is to install and copy from VST destination.
Some people are afraid to run exe files because it's always a security risk.
An ideal solution would be to create a zip distributable near the installer exe file. I am not sure how difficult would it be.

@glenclayton
Copy link
Author

I can take a look into implementing this if @sdatkinson is supportive. There are 2 options - either include the .vst3 file in the current zip package, or create a separate one just for it.

@sdatkinson
Copy link
Owner

This issue would be convenience improvement, because different apps lookup different paths for VST-s and sometimes people have to copy from the install destination.

It seems to me like specifying the install location would be preferable and more in line with what I usually see? If this isn't part of it right now (I don't remember), then opening an Issue regarding it would be fine.

Also not everyone needs the stand alone app, only the VST.

The installer currently allows you to select which parts to install, so I think this part is ok.

Some people are afraid to run exe files because it's always a security risk.

That doesn't seem like a good reason--executable installers are the norm, and I'm happy to stick with it. It does sound reasonable, though to ask for signed installers so that Windows & Mac will stop shouting so much 😉 This is tracked in #185.

An ideal solution would be to create a zip distributable near the installer exe file. I am not sure how difficult would it be.

I'm actually not really keen to add artifacts to the releases--there has been confusion in the past when users saw more than one thing that looked like it might be the right thing to download. Given that lesson, I'd like to keep it to one artifact per OS.


Since I think that the points in this issue are either resolved or would be better tracked in a narrower-scoped issue, I'm closing this.

@sdatkinson sdatkinson added the wontdo This will not be worked on label May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:low Low priority issues wontdo This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants