3.x: Adjust for zero token nodes (option B) #400
+344
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bouncheck
force-pushed
the
scylla-3.x-zero-token-ITs-v2
branch
from
e54498a to
25e4465
Compare
|
Made another version with different approach according to suggestions. @dkropachev we can choose which one to proceed with. |
Bouncheck
force-pushed
the
scylla-3.x-zero-token-ITs-v2
branch
from
25e4465 to
3d377bc
Compare
Adds ZeroTokenNodesIT that checks the behaviour of the driver when zero-token nodes are involved. Adds two options that control if peers that do not own any tokens are considered valid and if peers that do not own any tokens are considered for query planning. Query planning setting does not by default override LBP behavior. DCAwareRoundRobinPolicy, RackAwareRoundRobinPolicy and RoundRobinPolicy were adjusted to follow this setting. Driver behavior with those options disabled, which is the default option, should remain unchanged.
Bouncheck
force-pushed
the
scylla-3.x-zero-token-ITs-v2
branch
from
3d377bc to
fc5391b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ZeroTokenNodesIT that checks the behaviour of the driver when zero-token nodes are involved.
Adds two options that control if peers that do not own any tokens are considered valid and if peers that do not own any tokens are considered for query planning.
Query planning setting does not by default override LBP behavior. DCAwareRoundRobinPolicy, RackAwareRoundRobinPolicy and RoundRobinPolicy were adjusted to follow this setting.
Driver behavior with those options disabled, which is the default option, should remain unchanged.