-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decorator helper #4
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Looks neat! Would it still work to plot into a single panel of an existing figure? e.g. fig, (ax1, ax2) = plt.subplots(2,1)
plot_umap(adata, ax=ax2) |
The API is unchanged from As said, the only problem is that Python’s typing doesn‘t actually support modifying kwargs, so as neat as this would be, without a PEP to change this, we’ll have to go the more complicated route. Or have the function have See https://discuss.python.org/t/type-hints-for-kwarg-overrides/47196/7 |
The “only” problem is that this isn’t actually supported: python/mypy#14832, https://discuss.python.org/t/type-hints-for-kwarg-overrides/47196
If it was, it would have the advantage that we wouldn’t have to manually write overloads for each individual function.