feat(scully): adding support for project.json with no angular.json or workspace.json #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navneet10sep
suggested changes
Apr 19, 2023
|
@navneet10sep @SanderElias I've looked at the package-based stuff a little bit and I'm just not clear on how to add an angular app to a package-based nx repo therefore not sure if scully needs to support this. |
|
@sonicparke We are working on an entire new schematics. (with we, I mean @Jefiozie and @bampakoa, and me cheering on the sideline ;) ) |
|
Bump, i tested this it seems to work for me, except for ProjectName which if in another subfolder in 'apps' then i havve to do something like 'apps/frontend' can we get this merged in? i dont want to use the fork version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, individual
project.jsonfiles in each app are supported but scully still looks for the project path in eitherworkspace.jsonorangualr.jsonand expects theprojectsobject to exist. With the latest versions of Nx all the project configs have been migrated into the app folders andworkspace.json&angular.jsonare removed.Issue Number: #1520
What is the new behavior?
If there is no
projectsobject inangular.jsonorworkspace.jsonscully will then look forproject.jsonis theapps/[project]folder.Does this PR introduce a breaking change?
Other information