cleanup: remove legacy patches #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightsing
commented
Jan 2, 2025
| @@ -416,10 +416,6 @@ pub fn call<H: Host + ?Sized, SPEC: Spec>(interpreter: &mut Interpreter, host: & | |||
| interpreter.instruction_result = InstructionResult::FatalExternalError; | |||
| return; | |||
| }; | |||
| #[cfg(feature = "scroll")] | |||
| if account_load.is_cold && host.is_address_in_access_list(to) { | |||
| panic!("access list account should be either loaded or never accessed"); | |||
There was a problem hiding this comment.
Those checks panics immediately, it should be safe to remove those.
lightsing
changed the title
|
Ignore those ethtests failures, they are also failed in upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those legacy codes are not needed anymore
Changes
Important Notes
For
TxL1Msg, you need set thechain_idinTxEnvtoNoneto disable the chain_id check.Removed
scroll-poseidon-codehashfeature: poseidon not used anymoreordered-cache-dbfeature: previous used by sp1 poseidon hintsload_access_list#27) (fix: ignore failures in load_access_list #37) (if scroll reth witness still have same issue like geth mpt proofs, we will retrieve back this)code_sizefield in Account modelEnv::validate_tx, which can be replace by setchain_idtoNone