feat: pipelined state processor for follower nodes #894
+94
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerfirmak
commented
Jul 10, 2024
omerfirmak
force-pushed
the
omerfirmak/pipelined-processor
branch
from
5af7ab1 to
e0b317b
Compare
0xmountaintop
approved these changes
Jul 11, 2024
Thegaram
reviewed
Jul 12, 2024
| defer pl.Release() | ||
|
|
||
| for _, tx := range block.Transactions() { | ||
| res, err := pl.TryPushTxn(tx) |
There was a problem hiding this comment.
Originally, we'd trace and ccc the whole block in one step (different ccc API).
By using a pipeline, we now process tx-by-tx in a pipelined manner. Are the CCC results the same? And do we gain a lot from this?
| } | ||
| } | ||
|
|
||
| func (p *Processor) Process(block *types.Block, statedb *state.StateDB, cfg vm.Config) (types.Receipts, []*types.Log, uint64, error) { |
There was a problem hiding this comment.
The original plan was to move CCC out of the block processing loop, so that it's not blocking it. By moving CCC from block_validator to Process here, it's still blocking block insertion, right? What do we gain here?
I feel like:
- CCC on follower nodes does not need to block block processing, it can happen completely async.
- We can run CCC for multiple blocks in parallel, we don't need to process blocks one-by-one. (But of course there might be memory concerns if we trace lots of blocks in parallel.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
brings ccc-enabled follower node performance in line with sequencer performance.
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?