Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Broken integration test caused by transcript (#715) #721

Merged
merged 3 commits into from
Dec 10, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion transcript/src/basic.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,13 @@ impl<E: ExtensionField> Transcript<E> for BasicTranscript<E> {
}

fn read_challenge(&mut self) -> Challenge<E> {
let r = E::from_bases(self.permutation.squeeze());
// notice `from_bases` and `from_limbs` has the same behavior but
// `from_bases` has a sanity check for length of input slices
// while `from_limbs` use the first two fields silently
// we select `from_base` here to make it being more clear that
// we only use the first 2 fields here to construct the
// extension field (i.e. the challenge)
let r = E::from_bases(&self.permutation.squeeze()[..2]);

Challenge { elements: r }
}
Expand Down