-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add range table circuit #154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A first pass of review and some thoughts of the designs :)
ca8131c
to
52baa91
Compare
52baa91
to
e819215
Compare
@hero78119 I also changed the interface of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new change looks pretty me 🔥
just left some chore comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except some left over comments, others LGTM!
Fixes #109. - [x] add range circuit and unit test - [x] add prover for table circuits: `create_table_proof`. - [x] add verifier for table circuits: `verify_table_proof`.
Fixes #109. - [x] add range circuit and unit test - [x] add prover for table circuits: `create_table_proof`. - [x] add verifier for table circuits: `verify_table_proof`.
Fixes #109. - [x] add range circuit and unit test - [x] add prover for table circuits: `create_table_proof`. - [x] add verifier for table circuits: `verify_table_proof`.
Fixes #109.
create_table_proof
.verify_table_proof
.\prod read_evals[i] = \prod write_evals[i]
\sum_{i \in opcode circuits} fraction(logup_evals[i]) = \sum_{j \in table circuits} fraction(logup_evals[j])