Add delete_in argument #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terranisu
force-pushed
the
vadimka/support-deletion-period
branch
from
65317c4 to
af84bac
Compare
terranisu
force-pushed
the
vadimka/support-deletion-period
branch
from
af84bac to
483985a
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default Secrets Manager uses a 30 day recovery window to wait before permanently deleting the secret. In many cases, there is no need to wait for 30 days to delete a secret.
The PR exposes the
delete_inargument to configure the recovery window. The number of days must be between7and30. If the value is set to0it will trigger force deletion without recovery.Testing considerations
The change was tested in one of our root modules.
Checklist
Prefixed the PR title with the JIRA ticket codedevelopmentand/orstagingREADME.mdas necessaryRelated links