-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RoomVisual.poly to also accept positions #113
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that the PR works.
This misses one example of poly usage, which is also the example given in the screeps documentation - using an array of objects that contain x and y properties (e.g. a path).
Recommend changing to poly(points: Array<{x:number, y:number} | [number, number] | RoomPosition>, style?: PolyStyle): RoomVisual;
or equivalent.
Updated tsconfig.json newLine to meet new Typescript compiler casing requirements
The changes I've pushed allow objects meeting the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visually looks really good to me. Will explicitly test on prod scripts and check soon.
I tested these changes and was unable to declare a RoomVisual Need to add I know this has been languishing here, but hopefully we can get this repo updated and such |
Added constructor object instance for RoomVisual as per @thaelina's suggestion and rebuilt. |
From the documentation: