Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support *:nth-of-type through XPath extension function #73

Closed
wants to merge 1 commit into from
Closed

[WIP] Support *:nth-of-type through XPath extension function #73

wants to merge 1 commit into from

Conversation

redapple
Copy link
Contributor

@redapple redapple commented Nov 22, 2016

Very rough start at supporting *:nth-of-type(an+b)

scrapy/cssselect#4 looks impossible to translate in pure XPath 1.0, but is doable with custom XPath functions.

To do:

  • test more an+b cases
  • test *:first-of-type, *:last-of-type, *:only-of-type
  • test with namespaces
  • refactor to use a namespace prefix and a seperate module for custom XPath functions (custom xpath support #13 (comment) and subsequent comment)

@codecov-io
Copy link

codecov-io commented Nov 22, 2016

Current coverage is 96.10% (diff: 68.96%)

Merging #73 into master will decrease coverage by 3.89%

@@           master        #73   diff @@
========================================
  Files           4          4          
  Lines         203        231    +28   
  Methods         0          0          
  Messages        0          0          
  Branches       35         39     +4   
========================================
+ Hits          203        222    +19   
- Misses          0          6     +6   
- Partials        0          3     +3   

Powered by Codecov. Last update 08a11b5...dbfae26

@Gallaecio
Copy link
Member

Should we close this?

The reference to this pull request remain in #4, so anyone looking to work on this will not need to start from scratch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants