Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New ItemPage #74

Merged
merged 26 commits into from
Aug 25, 2022
Merged

New ItemPage #74

merged 26 commits into from
Aug 25, 2022

Commits on Aug 17, 2022

  1. Fixed fields in subclasses. Fixes GH-69.

    @kmike
    kmike committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    031fcec View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Merge branch 'master' into new-item-page

    @kmike
    kmike committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    aa8dec7 View commit details
    Browse the repository at this point in the history

  2. more type annotations

    @kmike
    kmike committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    9508871 View commit details
    Browse the repository at this point in the history

  3. items support using a generic ItemPage class

    @kmike
    kmike committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    352d8bb View commit details
    Browse the repository at this point in the history

  4. fix tests to account for new behavior

    @kmike
    kmike committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    7a772d7 View commit details
    Browse the repository at this point in the history

  5. tests for types

    @kmike
    kmike committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    4d33526 View commit details
    Browse the repository at this point in the history

  6. run types tests on github actions

    @kmike
    kmike committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    187733c View commit details
    Browse the repository at this point in the history

  7. fixed typing issues

    @kmike
    kmike committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    a509f44 View commit details
    Browse the repository at this point in the history

  8. backwards compat for Python 3.7

    @kmike
    kmike committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    fa947d8 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. more tests; skip_nonitem_fields argument

    @kmike
    kmike committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    d14ebd0 View commit details
    Browse the repository at this point in the history

  2. fix typing issue

    @kmike
    kmike committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    db2d875 View commit details
    Browse the repository at this point in the history

  3. extract SetItemType

    @kmike
    kmike committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    4b0d66e View commit details
    Browse the repository at this point in the history

  4. update fields tutorial

    @kmike
    kmike committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    706a22b View commit details
    Browse the repository at this point in the history

  5. rename SetItemType to Returns

    @kmike
    kmike committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    45107c4 View commit details
    Browse the repository at this point in the history

  6. typo fix

    @kmike
    kmike committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    dd03bc6 View commit details
    Browse the repository at this point in the history

  7. item_cls_fields -> skip_nonitem_fields

    @kmike
    kmike committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    161c46a View commit details
    Browse the repository at this point in the history

  8. added a comment to tox.ini temporary dependency

    @kmike
    kmike committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    58bd8e5 View commit details
    Browse the repository at this point in the history

  9. deprecate ItemWebPage

    @kmike
    kmike committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    05a9163 View commit details
    Browse the repository at this point in the history

  10. test WebPage + fields

    @kmike
    kmike committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    e452588 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2022

  1. clean up from-fround-up tutorial

    @kmike
    kmike committed Aug 20, 2022
    Configuration menu
    Copy the full SHA
    e74f123 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. Merge branch 'master' into new-item-page 

    # Conflicts:
#	docs/advanced/fields.rst
#	tests/test_fields.py
#	web_poet/pages.py
    @kmike
    kmike committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    b85bc1c View commit details
    Browse the repository at this point in the history

  2. typo fix

    @kmike
    kmike committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    99d3479 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Adrián Chaves <[email protected]>
Co-authored-by: Kevin Lloyd Bernal <[email protected]>
    @kmike @Gallaecio @BurnzZ
    3 people authored Aug 24, 2022
    Configuration menu
    Copy the full SHA
    5b01db1 View commit details
    Browse the repository at this point in the history

  2. ignore B024 flake8-bugbear warning

    @kmike
    kmike committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    0bdb50a View commit details
    Browse the repository at this point in the history

  3. more tests for ItemPage validation

    @kmike
    kmike committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    98c2627 View commit details
    Browse the repository at this point in the history

  4. mention to_item earlier in docs

    @kmike
    kmike committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    28f917a View commit details
    Browse the repository at this point in the history