Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POP - fundamental docs #28

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

POP - fundamental docs #28

wants to merge 4 commits into from

Conversation

BurnzZ
Copy link
Contributor

@BurnzZ BurnzZ commented Mar 1, 2022

Built on top of the branch from #27 which aims to define the minimum specifications/requirements to be a POP.

@BurnzZ BurnzZ requested a review from kmike March 1, 2022 14:13
@BurnzZ BurnzZ changed the base branch from master to handle_urls_mvp March 1, 2022 14:13
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #28 (6e50379) into handle_urls_mvp (414e8e6) will not change coverage.
The diff coverage is n/a.

❗ Current head 6e50379 differs from pull request most recent head e256b96. Consider uploading reports for the commit e256b96 to get more accurate results

@@                Coverage Diff                @@
##           handle_urls_mvp       #28   +/-   ##
=================================================
  Coverage           100.00%   100.00%           
=================================================
  Files                    6         5    -1     
  Lines                  206       132   -74     
=================================================
- Hits                   206       132   -74     
Impacted Files Coverage Δ
web_poet/mixins.py 100.00% <0.00%> (ø)
web_poet/__init__.py 100.00% <0.00%> (ø)
web_poet/overrides.py 100.00% <0.00%> (ø)
web_poet/page_inputs.py 100.00% <0.00%> (ø)
web_poet/utils.py


.. code-block:: python

from ecommerce_page_objects import RULES
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When deploying a POP behind an API, the separate deployment CLI-tool can have a configuration file that points to this entry point variable.

For example, such config file could be named pop.cfg which is basically:

[deploy]
rules = ecommerce_page_objects.RULES

[projects]
dev = 123
prod = 7890

@BurnzZ BurnzZ force-pushed the pop branch 2 times, most recently from 5eed2dc to 8e805a7 Compare March 29, 2022 09:07
@BurnzZ BurnzZ changed the title Docs for Page Object Project POP - fundamental docs Mar 29, 2022
@BurnzZ BurnzZ changed the base branch from handle_urls_mvp to master April 11, 2022 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant