Restore and improve the annotated dynamic deps support. #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs fix is in #209 |
wRAR
changed the title
Gallaecio
approved these changes
Oct 8, 2024
kmike
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick fix for a regression in #207 that raised an exception for annotated types.
The proper annotated dynamic deps support including support for multiple annotated deps requires some refactoring and logic changes and will be done separately.
Edit: as the most basic fix doesn't work on 3.9 I added a better one that includes support for multiple annotated deps but not other things that are still needed.
Edit 2: here is hopefully the complete fix, with making the results not annotated.