Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover 0.15.1 in the release notes #163

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

Gallaecio
Copy link
Member

No description provided.

@Gallaecio Gallaecio marked this pull request as ready for review September 15, 2023 07:42
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #163 (47b4fe9) into master (3706836) will not change coverage.
The diff coverage is n/a.

❗ Current head 47b4fe9 differs from pull request most recent head 588e32a. Consider uploading reports for the commit 588e32a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #163   +/-   ##
=======================================
  Coverage   85.67%   85.67%           
=======================================
  Files          14       14           
  Lines         803      803           
=======================================
  Hits          688      688           
  Misses        115      115           

@Gallaecio Gallaecio merged commit e6c5801 into scrapinghub:master Sep 15, 2023
13 checks passed
@@ -2,6 +2,15 @@
Changelog
=========

0.15.1 (2023-09-15)
-------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this release contains a new feature and a backwards incompatible change, it would have been better to release it as 0.16.0 :) Not a big deal though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was not sure whether or not to consider stat name changes backward-incompatible, but they indeed can be, and anyone tracking them with Spidermon might get their expectations broken 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants