-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Injector stats #161
Injector stats #161
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
==========================================
+ Coverage 85.62% 85.67% +0.05%
==========================================
Files 14 14
Lines 800 803 +3
==========================================
+ Hits 685 688 +3
Misses 115 115
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I do wonder if we should mention in the Stats page of the documentation the stats that are logged beyond those that are created using web-poet stats. Or maybe just mention the kind of stuff that’s logged, without going into detail.
@Gallaecio I'll add a short note to docs, without details though. |
@Gallaecio when this could potentially be merged and released? |
Thanks @proway2! |
Fixes #158
poet/*
pytest-twisted
is added torequirements-dev.txt
otherwise it's impossible to set up the local env (tox works fine in any case)