-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amend scrapy open_in_browser tool. #154
Amend scrapy open_in_browser tool. #154
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #154 +/- ##
==========================================
+ Coverage 85.36% 85.38% +0.02%
==========================================
Files 14 14
Lines 779 787 +8
==========================================
+ Hits 665 672 +7
- Misses 114 115 +1
|
Python 3.7 is end-of-life, so rather than looking for a compatible approach, feel free to modify the code base (tox.ini, setup.py, README) to drop 3.7 support. |
@Gallaecio fixed in #155 :) |
Now that tests pass, I think the only missing piece is docs. I am not sure where to mention it, though. Maybe a new, short section in https://scrapy-poet.readthedocs.io/en/stable/intro/pitfalls.html , just so that we can link to it when people run into the issue? |
@Gallaecio added help section, please review. |
Fixes #91
The error: