Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide API for loading SDF file without converting it to latest supported version #220

Open
scpeters-test opened this issue Sep 16, 2019 · 1 comment
Open

Provide API for loading SDF file without converting it to latest supported version #220

scpeters-test opened this issue Sep 16, 2019 · 1 comment
Labels
enhancement New feature or request major

Comments

@scpeters-test
Copy link
Collaborator

Original report (archived issue) by Steve Peters (Bitbucket: Steven Peters).

Summary

The sdf::readFile and sdf::readString functions in parser.hh convert file to the latest SDF version. It would be nice to provide an API that loads the file at its current version without conversion.

Motivation

It would allow 3rd parties that use the sdformat parser time to migrate from an older version of the spec to the newest one.

Describe alternatives you've considered

Tell users to read the /sdf[@version] attribute and pass it to sdf::convertFile to load the file at the specific version. Providing a dedicated API would simplify this process.
@scpeters-test
Copy link
Collaborator Author

Original comment by Steve Peters (Bitbucket: Steven Peters).

added bool parameter to sdf::readFile and sdf::readString in pr #647

@scpeters-test scpeters-test added major enhancement New feature or request labels Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants