Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converter::Rename only renames the first element #218

Open
scpeters-test opened this issue Aug 27, 2019 · 0 comments
Open

Converter::Rename only renames the first element #218

scpeters-test opened this issue Aug 27, 2019 · 0 comments
Labels
bug Something isn't working minor

Comments

@scpeters-test
Copy link
Collaborator

Original report (archived issue) by Steve Peters (Bitbucket: Steven Peters).


During review of pull request #551, which fixed the Converter::Remove function to remove repeated elements, @azeey pointed out that Converter::Rename has the same problem in that it only renames the first element and not any repeated elements. I have confirmed this by adding a failing test to the following branch:

@scpeters-test scpeters-test added minor bug Something isn't working labels Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor
Projects
None yet
Development

No branches or pull requests

0 participants