Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

519 add samplingignore logic #521

Merged
merged 11 commits into from
Jan 14, 2025
Merged

519 add samplingignore logic #521

merged 11 commits into from
Jan 14, 2025

Conversation

mitchh456
Copy link
Contributor

No description provided.

@mitchh456 mitchh456 linked an issue Jan 3, 2025 that may be closed by this pull request
@mitchh456 mitchh456 changed the base branch from master to 518-add-and-parse-new-configurations January 3, 2025 18:47
@mitchh456 mitchh456 force-pushed the 519-add-samplingignore-logic branch from 2ba429b to db2f396 Compare January 3, 2025 20:22
@mitchh456 mitchh456 force-pushed the 518-add-and-parse-new-configurations branch from e609a84 to 8af707c Compare January 6, 2025 13:37
@mitchh456 mitchh456 force-pushed the 519-add-samplingignore-logic branch from e8e5e65 to 73375ff Compare January 6, 2025 13:55
Base automatically changed from 518-add-and-parse-new-configurations to master January 6, 2025 16:43
@mitchh456 mitchh456 force-pushed the 519-add-samplingignore-logic branch from 73375ff to c66dcd5 Compare January 6, 2025 16:45
@quinnmil
Copy link

quinnmil commented Jan 7, 2025

Is this supporting wildcard (/foo/*) controller/job names yet?

@mitchh456
Copy link
Contributor Author

mitchh456 commented Jan 8, 2025

Is this supporting wildcard (/foo/*) controller/job names yet?

There is prefix matching for endpoints. ignore_uri? and sample_uri? use regex match. I copied it from existing IgnoreUris module. I don't think there's a need for explicitly matching wildcard * or supporting user defined regex.

Do we want regex/prefix match for job names or just explicit? This is something I thought about yesterday. At least in Rails job names are usually something like MyModule::MyJob. Maybe at least module match or something.

@mitchh456 mitchh456 merged commit 5fd6d92 into master Jan 14, 2025
30 checks passed
@mitchh456 mitchh456 deleted the 519-add-samplingignore-logic branch January 14, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sampling/ignore logic
2 participants