Fixes for CSS double-includes / override behavior #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ready by app.less; otherwise they get packaged twice into app.css.
|
Excellent work @tdumitrescu! Thank you very much for doing this! |
kylefinley
added a commit
that referenced
this pull request
Nov 30, 2013
Fixes for CSS double-includes / override behavior, Thanks @tdumitrescu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kylefinley is this roughly what you were looking for in #91?
It turns out that not only was Bootstrap being included twice in
app.css, but also the files included inapp.less(overrides and variables). I moved those includes into a separate directory so that they could easily be ignored (but still watched) without a bunch of extra code inconfig.coffee.I noticed some differences in margin behavior at >1200px wide; this is because the old version had vanilla Bootstrap re-imported at the end, essentially re-overriding some previous overrides and media queries. Not sure whether you consider that a good or bad thing...