Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task card icon #302

Merged
merged 18 commits into from
Aug 30, 2022
Merged

Task card icon #302

merged 18 commits into from
Aug 30, 2022

Conversation

PrerakMathur20
Copy link
Contributor

@PrerakMathur20 PrerakMathur20 commented Aug 23, 2022

Description

To improve visibility and appearance, with help of Material UI, Task Icons, and Edit Task icons have been added.
For obvious reasons, a "✔️" is easier to read rather than "Mark Completed", and/or "Mark Incomplete".

NOTE: Edit button is dormant as of now. And functionality is yet to be added.
Edit Button Functionality to be added via #288

Fixes #301

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

None required.

Also, include screenshots for the verification and reviewing purpose.

  • Task Completed Card with Edit Icon

Screenshot 2022-08-23 at 3 10 06 PM

  • Task Incomplete Card with Edit Icon

Screenshot 2022-08-23 at 3 09 59 PM

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (N/A)
  • New and existing unit tests pass locally with my changes (N/A)
  • Any dependent changes have been merged and published in downstream modules (N/A)

@PrerakMathur20 PrerakMathur20 self-assigned this Aug 24, 2022
@PrerakMathur20
Copy link
Contributor Author

I have made the changes asked. Kindly review them.

@swapnalshahil swapnalshahil merged commit 1b8410f into scorelab:master Aug 30, 2022
@PrerakMathur20 PrerakMathur20 added the gsoc-2022 Google Summer of Code 2022 label Sep 5, 2022
@PrerakMathur20 PrerakMathur20 deleted the TaskCardIcon branch September 28, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc-2022 Google Summer of Code 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Add icons to task card
2 participants