-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(provisioner) Add a default mssql
provisioner
#73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Hentouane for your contribution.
I have left a few comments for updates.
Also, you need to sign your commits to be compliant with the DCO check, see here how to resolve it: https://github.com/score-spec/score-k8s/runs/31986670494.
294d594
to
61f015a
Compare
Signed-off-by: Hentouane <[email protected]>
Signed-off-by: Hentouane <[email protected]>
Signed-off-by: Hentouane <[email protected]>
Signed-off-by: Hentouane <[email protected]>
Commits were signed-off and changes were applied. Leaving one conversation open as to confirm reviewer's approval. |
Thanks, @Hentouane! LGTM @astromechza, another pair of eyes for this review please? Thanks1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, this looks good to me! Definitely a good starting point for those using mssql
Thanks @Hentouane 👍
mssql
provisioner
Adding a new default provider for a mssql database.
Description
Created a new default provider template for a mssql db based on already existing mysql and postgres ones. Updated zz-default.provisioners.yaml and README.md.
What does this PR do?
Adding a new default provider for a mssql database per feature request #66
Was tested with the following score.yaml file:
Once deployed in a k3s cluster, the following was succesfully logged by the test-container:
Types of changes
Checklist: