#57 Fix bug where score-k8s creates the score.yaml with perm 0600 instead of 0755 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…600 instead of 0755 Signed-off-by: Somsubhra Bairi <[email protected]>
Somsubhra
force-pushed
the
fix-score-yaml-perm
branch
from
89fbaaa to
f25c92d
Compare
mathieu-benoit
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Thanks for your contribution, @Somsubhra, much appreciated!
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where score-k8s creates the score.yaml with perm 0600 instead of 0755.
Description
Fix bug where score-k8s creates the score.yaml with perm 0600 instead of 0755. This is to keep it consistent with other commands like scope-compose which creates it with 0755 perm. Also the ci workflow has been changed to cat the file rather than listing it.
What does this PR do?
Types of changes
Checklist: