Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

October 30th - Sync with main #48

Open
wants to merge 124 commits into
base: main
Choose a base branch
from

Conversation

KirbyRider1337
Copy link
Contributor

Here we are. Rezzo may not be around, but that doesn't mean we can't sync. Now, perhaps we'll do this again at the start of Gen 10.

Karthik99999 and others added 30 commits January 8, 2024 13:45
Apparently that's why that was broken.
Credits to igeu  , xerneas9050 and dhwna for the translation, aegii for the formatting.
Been spending some time processing the last decade of my life, including reading
some old logs from the period where this user was banned, and I've decided that
I have to make this commit to be able to move on.
Karthik99999 and others added 27 commits August 17, 2024 12:41
Didn't test this change at all, but it's needed and nobody is reviewing it in a timely manner.
This isn't actually too hard to backport to the old client, but I'll
leave that for someone else.

This is here partly as a tech demo of the syntax highligher, which I
plan to use in the teambuilder.
* Use only current line in tab-completing commands

https://www.smogon.com/forums/threads/bug-report.3749269/

At this point, it's a bit more than a bug fix.

* Update client-chat.js

Changed stuff that npm run test did not like.

* Restore subcommand behavior
Limited to use by the main server for obvious reasons. Intended to use for linking PS-Smogon accounts. No one should be using this otherwise, but just in case I've put an interstice guard on any non-whitelisted links.
* Update VGC names

* Remove deprecated metagames

* Update ladder.php

* Update users.php

* Update pokemonshowdown.com/users.php

---------

Co-authored-by: Kris Johnson <[email protected]>
Previous one was deprecated and being phased out.
* Add animation for Thunderclap

* Add sparks before Thunderclap bolt

* Satisfy linter
Of course there's probably bugs still lurking around but this should be most of the changes
@KirbyRider1337 KirbyRider1337 marked this pull request as draft October 30, 2024 21:44
@KirbyRider1337
Copy link
Contributor Author

It at least functions (you can battle and everything) but I only did one test battle, so there may be many potential cracks in the system I didn't catch.

@KirbyRider1337 KirbyRider1337 marked this pull request as ready for review December 26, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.