snet: fix UDP port selection on Windows #4656
Conversation
|
This change is |
There was a problem hiding this comment.
It doesn't seem necessary to duplicate the code. If the only difference is the value of the error code, then please make a windows and unix versions of just that constant (of a function that abstracts iit to "thisIsTheErrorYourLookingFor()".
Reviewed 1 of 4 files at r1, all commit messages.
Reviewable status: 1 of 4 files reviewed, all discussions resolved
There was a problem hiding this comment.
I created a function errorIsAddrUnavailable() to test if the error code indicates an unavailable port as there are at least two error codes indicating this kind of situation in Windows.
Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @jiceatscion)
There was a problem hiding this comment.
Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @lschulz)
lschulz
force-pushed
the
windows-snet
branch
from
8eeea5f to
4967f9f
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
SNET is checking the wrong error code when probing for available UDP ports.
Windows socket error codes are completely different from Linux, thus different OSes must be distinguished.