build: bump go version to 1.23 #4603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required upgrading rules_go to 0.47.0 because of some magic parameter that must now be passed to the go assembler in support of the internal/V0 ABI split in go 1.22. It wasn't possible to upgrade rules_go further without also upgrading bazel and other stuff. So... one problem at a time. As a result of rules_go upgrade, the proto generation has changed, hence the other diffs.
|
This change is |
lukedirtwalker
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Reviewed 22 of 22 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jiceatscion)
lukedirtwalker
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
This resulted in a few new complaints. Also reformated WORSPACE.
lukedirtwalker
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status:
lukedirtwalker
added a commit
to lukedirtwalker/scion
that referenced
this pull request
Sep 3, 2024
This reverts commit 9e58974.
oncilla
added a commit
to oncilla/scion
that referenced
this pull request
Sep 13, 2024
This reverts commit 9e58974.
oncilla
added a commit
to oncilla/scion
that referenced
this pull request
Sep 13, 2024
This reverts commit 9e58974.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required upgrading rules_go to 0.47.0 because of some magic parameter that must now be passed to the go assembler in support of the internal/V0 ABI split in go 1.22.
It wasn't possible to upgrade rules_go further without also upgrading bazel and other stuff. So... one problem at a time.
As a result of rules_go upgrade, the proto generation has changed, hence the other diffs.
Contributes to #4555