Skip to content

Commit

Permalink
fix broken rebase
Browse files Browse the repository at this point in the history
  • Loading branch information
JordiSubira committed Sep 28, 2023
1 parent 8264f40 commit 93b4afb
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 13 deletions.
17 changes: 10 additions & 7 deletions acceptance/hidden_paths/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,12 @@ def setup_prepare(self):
"4": "172.20.0.65",
"5": "172.20.0.73",
}
control_addresses = {
"2": "172.20.0.51:30090",
"3": "172.20.0.59:30090",
"4": "172.20.0.67:30090",
"5": "172.20.0.75:30090",
}
# Each AS participating in hidden paths has their own hidden paths configuration file.
hp_configs = {
"2": "hp_groups_as2_as5.yml",
Expand Down Expand Up @@ -101,16 +107,13 @@ def setup_prepare(self):
# even though some don't need the registration service.
as_dir_path = self.artifacts / "gen" / ("ASff00_0_%s" % as_number)

# The hidden_segment services are behind the same server as the control_service.
topology_file = as_dir_path / "topology.json"
control_service_addr = scion.load_from_json(
'control_service.%s.addr' % control_id, [topology_file])
topology_update = {
"hidden_segment_lookup_service.%s.addr" % control_id:
control_service_addr,
control_addresses[as_number],
"hidden_segment_registration_service.%s.addr" % control_id:
control_service_addr,
control_addresses[as_number],
}
topology_file = as_dir_path / "topology.json"
scion.update_json(topology_update, [topology_file])

def setup_start(self):
Expand Down Expand Up @@ -156,4 +159,4 @@ def configuration_server(server):


if __name__ == "__main__":
base.main(Test)
base.main(Test)
8 changes: 2 additions & 6 deletions private/app/appnet/infraenv.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ func (nc *NetworkConfig) TCPStack() (net.Listener, error) {

func (nc *NetworkConfig) QUICStack() (*QUICStack, error) {
if nc.QUIC.Address == "" {
nc.QUIC.Address = nc.Public.String()
nc.QUIC.Address = net.JoinHostPort(nc.Public.IP.String(), "0")
}

client, server, err := nc.initQUICSockets()
Expand Down Expand Up @@ -293,11 +293,7 @@ func (nc *NetworkConfig) initSvcRedirect(quicAddress string) (func(), error) {
Metrics: nc.SCIONNetworkMetrics,
}

// The service resolution address gets a dynamic port. In reality, neither the
// address nor the port are needed to address the resolver, but the dispatcher still
// requires them and checks unicity. At least a dynamic port is allowed.
srAddr := &net.UDPAddr{IP: nc.Public.IP, Port: 0}
conn, err := network.Listen(context.Background(), "udp", srAddr, addr.SvcWildcard)
conn, err := network.Listen(context.Background(), "udp", nc.Public, addr.SvcWildcard)
if err != nil {
return nil, serrors.WrapStr("listening on SCION", err, "addr", conn.LocalAddr())
}
Expand Down

0 comments on commit 93b4afb

Please sign in to comment.