Skip to content

Commit

Permalink
router: leftovers cleanup.
Browse files Browse the repository at this point in the history
That is:
* Fix description of end2end.go.
* Delete NilCtx(), no-longer used.
  • Loading branch information
jiceatscion committed Nov 16, 2023
1 parent eea565f commit 91b7e22
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 18 deletions.
6 changes: 0 additions & 6 deletions private/tracing/context.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,3 @@ func StartSpanFromCtx(ctx context.Context, operationName string,

return opentracing.StartSpanFromContext(ctx, operationName, opts...)
}

// Allow the construction of nil-valued spans (and context) without leaking
// opentracing types.
func NilCtx() (opentracing.Span, context.Context) {
return nil, nil
}
16 changes: 4 additions & 12 deletions tools/end2end/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,10 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// This is a general purpose client/server code for end2end tests. It plays
// ping-pong with some variantions depending on command line arguments.
//
// One of the variants is for the client to send pings to the server
// until it receives at least one pong from the server or a given
// deadline was reached. The server responds to pings and the client
// wait for a response before doing anything else.
//
// Another variant is for the client to send back-to-back pings to the
// server until the sending fails or some deadline was reached. In this case
// the client isn't waiting for responses. The client checks at the end
// whether at least one response has been received.
// This is a general purpose client/server code for end2end tests. The client
// sends pings to the server until it receives at least one pong from the
// server or a given deadline is reached. The server responds to all pings and
// the client wait for a response before doing anything else.

package main

Expand Down

0 comments on commit 91b7e22

Please sign in to comment.