Skip to content

Commit

Permalink
router: do not build a private router image for the newbenchmark test.
Browse files Browse the repository at this point in the history
There's no reason to do that, we can just use the same image that's used for
everything else.
  • Loading branch information
jiceatscion committed Nov 24, 2023
1 parent f84224c commit 7cf275e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
9 changes: 3 additions & 6 deletions acceptance/router_newbenchmark/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ exports_files([
args = [
"--executable",
"brload:$(location //acceptance/router_newbenchmark:brload)",
"--container-loader=posix-router:latest#$(location //docker:posix_router)"
]

data = [
":conf",
":router",
"//docker:posix_router",
":brload",
]

Expand All @@ -54,12 +55,8 @@ raw_test(
src = "test.py",
args = args,
data = data,
homedir = "$(rootpath :router)",
homedir = "$(rootpath //docker:posix_router)",
# This test uses sudo and accesses /var/run/netns.
local = True,
)

container_image(
name = "router",
base = "//docker:posix_router",
)
2 changes: 1 addition & 1 deletion acceptance/router_newbenchmark/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ def setup_prepare(self):
"-e SCION_EXPERIMENTAL_BFD_DISABLE=true -e GOMAXPROCS=4 "
"--network container:prometheus "
"--name router "
"bazel/acceptance/router_newbenchmark:router")
"posix-router:latest")

time.sleep(2)

Expand Down

0 comments on commit 7cf275e

Please sign in to comment.