Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare SCION AS numbers independant from BGP ASNs. #10

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Declare SCION AS numbers independant from BGP ASNs. #10

merged 2 commits into from
Feb 22, 2024

Conversation

jiceatscion
Copy link
Contributor

This is my proposal to address the scion/BGP AS number objection.

Fixes #9

@jiceatscion jiceatscion requested a review from cdekater as a code owner January 9, 2024 10:36
@nicorusti nicorusti requested review from nicorusti and removed request for cdekater February 22, 2024 18:19
nicorusti
nicorusti approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@nicorusti nicorusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited a bit of wording, it overall looks good to me.

@nicorusti nicorusti merged commit 5bef5e2 into main Feb 22, 2024
2 checks passed
@nicorusti nicorusti deleted the AS_num branch February 22, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicorusti nicorusti nicorusti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt Section on SCION AS Numbers
2 participants
@jiceatscion @nicorusti