Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF - fixed voxel bundary conditions in uncompress streamlines #1098

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gabknight
Copy link
Contributor

@gabknight gabknight commented Dec 12, 2024

Quick description

Fixes issue #805.
Closes #805
Streamline voxel coordinates were moved by epsilon in the streamline direction if a coordinate was on the voxel boundary. This failed when the direction was co-aligned with the voxel grid. This PR move the coordinate by epsilon in the perpendicular direction instead.

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.47%. Comparing base (e256482) to head (0334e7d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1098   +/-   ##
=======================================
  Coverage   69.46%   69.47%           
=======================================
  Files         447      447           
  Lines       24052    24052           
  Branches     3291     3291           
=======================================
+ Hits        16708    16709    +1     
+ Misses       5946     5944    -2     
- Partials     1398     1399    +1     
Components Coverage Δ
Scripts 70.26% <ø> (ø)
Library 68.40% <ø> (+<0.01%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in uncompress from scilpy/tractograms/uncompress.pyx
1 participant