-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RF - Input to volume stats scripts #1068
base: master
Are you sure you want to change the base?
Conversation
Hello @gabknight, Thank you for updating !
Comment last updated at 2025-01-23 16:26:56 UTC |
4c185ea
to
7079040
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1068 +/- ##
==========================================
+ Coverage 69.52% 69.56% +0.03%
==========================================
Files 448 448
Lines 24087 24108 +21
Branches 3295 3301 +6
==========================================
+ Hits 16747 16770 +23
+ Misses 5945 5942 -3
- Partials 1395 1396 +1
|
@gabknight I gave it a try and there are some errors when I use the metrics_dir. |
hmm, it seems the error was unrelated to this PR. Should have tested it though, thanks for checking. Could you re-test now? |
a45f561
to
fe35d8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems ok! Small comment on the --help.
fe35d8e
to
fa86a0a
Compare
Thanks for the review @EmmaRenauld. The doc has been fixed/improved. |
Quick description
Add new input features to
scil_volume_stats_in_labels.py
in_map
was replaced by the argument groupMetrics input options
, allowing for a list of metric filenames or a metric folder;metric
;add_json_args
and corresponding formatting to the output json;scil_volume_stats_in_ROI.py
in_mask
toin_rois
, allowing for multiple input mask.roi_name
;...
Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
...
Checklist