Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Update subworkflow preproc_t1 #35

Merged
merged 3 commits into from
Dec 1, 2024

Conversation

anroy1
Copy link
Contributor

@anroy1 anroy1 commented Nov 1, 2024

Type of improvement

  • Documentation
  • Development tools (e.g. linter, formatter, etc.)
  • Development container
  • Global update (please specify)
  • Other (please specify)

Describe your improvement

  • Adding .map() function to input channel structure to correctly manage empty optional channels
  • Removing the ants BET checks (template and probability map)

Checklist before requesting a review

  • Ensure the syntax is correct (EditorConfig and Prettier must pass)
  • Run the test suites if your changes affect any module
  • Regenerate the Poetry lock file if you have updated the dependencies
  • Ensure the documentation is up-to-date

@AlexVCaron
Copy link
Collaborator

Closes AlexVCaron#11

@anroy1 anroy1 force-pushed the fix-sub-preproc_t1 branch from dcd9d29 to 1835a03 Compare November 21, 2024 22:49
@anroy1 anroy1 force-pushed the fix-sub-preproc_t1 branch from 1835a03 to c19ae57 Compare November 29, 2024 18:52
@AlexVCaron AlexVCaron requested review from arnaudbore and AlexVCaron and removed request for GuillaumeTh November 29, 2024 19:24
Copy link
Collaborator

@AlexVCaron AlexVCaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on my end @arnaudbore should we have a discussion on optional input definition on beginning next week ?

Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@AlexVCaron
Copy link
Collaborator

I will add the comments on the joins with remainders in a separate PR

@AlexVCaron AlexVCaron added this pull request to the merge queue Dec 1, 2024
Merged via the queue into scilus:main with commit ee026cf Dec 1, 2024
15 checks passed
@anroy1 anroy1 deleted the fix-sub-preproc_t1 branch December 3, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants