Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #81: removed tex=True setting #82

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Conversation

maximelucas
Copy link
Contributor

Fixed #81 by removing line 15 mpl.rcParams["text.usetex"] = True

@catanzaromj
Copy link
Contributor

catanzaromj commented Jul 19, 2024

@maximelucas Thanks for this! Would you mind fixing the failing tests too? Can you switch out the older np.Inf calls to np.inf to fix these tests?

FAILED test/test_persistence_imager.py::test_fit_diagram - AttributeError: `np.Inf` was removed in the NumPy 2.0 release. Use `np.inf` instead.
FAILED test/test_persistence_imager.py::test_fit_diagram_list - AttributeError: `np.Inf` was removed in the NumPy 2.0 release. Use `np.inf` instead.
FAILED test/test_persistence_imager.py::TestTransformOutput::test_n_pixels - AttributeError: `np.Inf` was removed in the NumPy 2.0 release. Use `np.inf` instead.
FAILED test/test_persistence_imager.py::TestTransformOutput::test_multiple_diagrams - AttributeError: `np.Inf` was removed in the NumPy 2.0 release. Use `np.inf` instead.

To be clear, these lines need to be fixed.

Thanks

@catanzaromj catanzaromj self-requested a review July 19, 2024 12:37
@catanzaromj catanzaromj added the bug Something isn't working label Jul 19, 2024
@maximelucas
Copy link
Contributor Author

Done. I think that's due to the newest version of numpy, 2.0. You may want to put a ceiling on the allowed version in the requirements if other problems pop up.

@catanzaromj
Copy link
Contributor

Awesome, thanks!

@catanzaromj catanzaromj merged commit fcbe04a into scikit-tda:master Jul 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global rcParams change on import
2 participants