Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Catch invalid model specification with duplicate channels, samples and modifiers. #2396

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lorenzennio
Copy link
Contributor

@lorenzennio lorenzennio commented Dec 8, 2023

Description

Fixes #2059 but extends to channels and samples. We want to catch the case where we have multiple channels with the same name in the model specification, where the first of these would simply be ignored as of now. Similarly, this applies to samples with the same name in a given channel or modifiers with the same name and type in a given sample.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1a31f1) 98.28% compared to head (edea8ef) 98.28%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2396   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files          69       69           
  Lines        4539     4556   +17     
  Branches      803      814   +11     
=======================================
+ Hits         4461     4478   +17     
  Misses         45       45           
  Partials       33       33           
Flag Coverage Δ
contrib 97.87% <100.00%> (+<0.01%) ⬆️
doctest 60.66% <47.05%> (-0.06%) ⬇️
unittests-3.10 96.31% <100.00%> (+0.01%) ⬆️
unittests-3.11 96.31% <100.00%> (+0.01%) ⬆️
unittests-3.8 96.33% <100.00%> (+0.01%) ⬆️
unittests-3.9 96.35% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attaching modifiers twice to a sample
1 participant