Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

learn notebook for CLs asymptotics #1476

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

lukasheinrich
Copy link
Contributor

Description

produces this animation

anim

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Patch coverage has no change and project coverage change: -0.65 ⚠️

Comparison is base (a28d1a3) 98.30% compared to head (3f92552) 97.65%.

❗ Current head 3f92552 differs from pull request most recent head acc12fc. Consider uploading reports for the commit acc12fc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1476      +/-   ##
==========================================
- Coverage   98.30%   97.65%   -0.65%     
==========================================
  Files          69       64       -5     
  Lines        4534     4008     -526     
  Branches      802      565     -237     
==========================================
- Hits         4457     3914     -543     
- Misses         45       55      +10     
- Partials       32       39       +7     
Flag Coverage Δ
contrib 25.52% <ø> (-72.36%) ⬇️
doctest ?
unittests 97.43% <ø> (?)
unittests-3.10 ?
unittests-3.11 ?
unittests-3.8 ?
unittests-3.9 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 54 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert matthewfeickert added the docs Documentation related label May 26, 2021
@cranmer
Copy link

cranmer commented May 26, 2021

very cool. I would still suggest a transposed version of the top right plot. Maybe in the middle right panel?
I'd also suggest increasing the size of the axis labels a little.

Also, recommend matplotlib -> jshtml to include in static HTML
http://louistiao.me/posts/notebooks/embedding-matplotlib-animations-in-jupyter-as-interactive-javascript-widgets/

@lukasheinrich
Copy link
Contributor Author

ttherre is also an arrangement like tthis that has tthe CLs and the qµ distrtibutions in normal orientation and the gaussian µ^ distribution rotated

image

@matthewfeickert matthewfeickert changed the base branch from master to main September 21, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants