Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approximate CDF from PDF #950

Merged
merged 6 commits into from
Jan 31, 2024

Conversation

The-Ludwig
Copy link
Contributor

@The-Ludwig The-Ludwig commented Nov 22, 2023

  • make the description of the approximate CDF more precise
  • provide an example of how to generate an approximate CDF from a given PDF
  • comments out 2 lines so the notebook throws no errors (both related to the jacobi example)

@HDembinski
Copy link
Member

Hi @The-Ludwig I like the tutorial, but I think we should make it a separate short tutorial instead of embedding in the already very long cost_funtions.ipynb.

@HDembinski HDembinski force-pushed the approximate_cdf_tutorial branch from e041bae to 97b741c Compare December 7, 2023 14:53
@HDembinski
Copy link
Member

HDembinski commented Dec 8, 2023

@The-Ludwig Let's not touch this branch for now, I am working on a different solution. I also reworked the notebook that you changed, so I will merge this PR at some point.

If you want to work on something, you could make a new notebook which showcases the different ways of computing an cdf (approximate or with numerical integration) and showcase the pros and cons. You could explore the bias introduced by the approximate cdf and compare run-times. That would be really helpful

@HDembinski HDembinski force-pushed the approximate_cdf_tutorial branch from 70ea842 to 1597800 Compare January 31, 2024 16:34
@HDembinski HDembinski force-pushed the approximate_cdf_tutorial branch from 7aab095 to 935d2c9 Compare January 31, 2024 16:57
@HDembinski HDembinski merged commit a7058d2 into scikit-hep:develop Jan 31, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants