fix: include debug info on failures #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <[email protected]>
for more information, see https://pre-commit.ci
|
The newly detailed error: |
|
No, actually that's a separate issue / test failure. But I think NumPy 1.25-1.26 is likely causing the breakage (other than that warning as error above) by changing the C API to no longer convert implicitly, which is causing the pybind11 error. |
|
PS: Why is this only showing up in the coverage job? |
|
I need to investigate this further, thanks for this patch which helps. The coverage job runs more tests, that's why it fails while the other checks pass. |
|
Okay, great, let me know if I can help. |
HDembinski
pushed a commit
that referenced
this pull request
Dec 7, 2023
Adding debug info on failures. --------- Signed-off-by: Henry Schreiner <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, Adding debug info on failures.