feat: support simplecache url chaining
#42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After merging this PR a release would be needed in order to merge scikit-hep/uproot5#1075. |
|
Will this close #42 ? |
nsmith-
approved these changes
Dec 22, 2023
|
Go ahead and merge, also feel free to make a release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to scikit-hep/uproot5#1075.
I would like to add a test in uproot where we test the
simplecachebut the files I know of are too big, would it be possible to have a small test file hosted over xrootd so we can test it? (file would need to be downloaded whole).Edit: At the end I ended up adding an xrootd server fixture to uproot so we can test this on local files, so no need to add a new small file, but I don't think it'll hurt to add one in any case.