build: Use hatchling as build backend #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewfeickert
commented
May 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #475 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 2093 2093
Branches 346 346
=========================================
Hits 2093 2093 ☔ View full report in Codecov by Sentry. |
|
Thanks for taking care of this! The CI issues are from a matplotlib update, I'll take care of that separately. edit: see #476 |
matthewfeickert
force-pushed
the
build/use-hatchling
branch
from
5323f88 to
5d42eef
Compare
matthewfeickert
commented
May 21, 2024
matthewfeickert
force-pushed
the
build/use-hatchling
branch
2 times, most recently
from
5cd0096 to
c372840
Compare
|
@alexander-held This is ready for review again. I think the easiest spot check for you to do on this is if you checkout this branch to then do rm -rf dist && pipx run build --installer uv . && python -m tarfile --list dist/cabinetry-*.tar.gz && python -m zipfile --list dist/cabinetry-*.whlas that will show you the contents of the sdist and wheel getting built. You can compare that to the wheels currently on PyPI $ rm -rf cabinetry*.whl && python -m pip download --no-cache-dir --no-deps cabinetry && python -m zipfile --list cabinetry-*.whlDoing that:rm -rf dist && pipx run build --installer uv . && python -m tarfile --list dist/cabinetry-*.tar.gz && python -m zipfile --list dist/cabinetry-*.whl$ rm -rf cabinetry*.whl && python -m pip download --no-cache-dir --no-deps cabinetry && python -m zipfile --list cabinetry-*.whl |
matthewfeickert
force-pushed
the
build/use-hatchling
branch
from
c372840 to
139acac
Compare
|
@alexander-held bumping this, but we can probably both ignore this until next Friday once we've got most of the IRIS-HEP 2024 retreat finished. :) |
matthewfeickert
force-pushed
the
build/use-hatchling
branch
from
139acac to
a04d069
Compare
alexander-held
force-pushed
the
build/use-hatchling
branch
from
81cd337 to
a04d069
Compare
* Migrate to using hatchling as the build backend. - Include all build metadata in pyproject.toml. - Remove setup.py, setup.cfg, and MANIFEST.in. - Remove package_data as not needed. * Add .flake8 as flake8 won't support pyproject.toml.
* Remove check-manifest install in CI workflow. * Remove MANIFEST check step from CI.
alexander-held
force-pushed
the
build/use-hatchling
branch
from
a04d069 to
cd0865e
Compare
alexander-held
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to using hatchling as the build backend.
Add .flake8 as flake8 won't support pyproject.toml.
ci: Remove MANIFEST check from CI
(Marked as draft as wrote from Munich airport and need to check some things)