fix: a few mistakes

Signed-off-by: Henry Schreiner <[email protected]>
scikit-hep · Mar 28, 2024 · 214ecbe · 214ecbe
1 parent 4763476
commit 214ecbe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -19,7 +19,7 @@ jobs:
   clang-tidy:
     name: Clang-Tidy
     runs-on: ubuntu-latest
-    container: silkeh/clang:15-bullseye
+    container: silkeh/clang:18-bookworm
 
     steps:
       - name: Install requirements

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -65,7 +65,7 @@ file(GLOB_RECURSE BOOST_HIST_PY_HEADERS "include/bh_python/*.hpp")
 file(GLOB BOOST_HIST_PY_SRC CONFIGURE_DEPENDS src/*.cpp)
 
 # This is the Python module
-pybind11_add_module(_core SHARED ${BOOST_HIST_PY_HEADERS} ${BOOST_HIST_PY_SRC} ${BOOST_HIST_FILES})
+pybind11_add_module(_core MODULE ${BOOST_HIST_PY_HEADERS} ${BOOST_HIST_PY_SRC} ${BOOST_HIST_FILES})
 
 # Add the include directory for boost/histogram/python
 target_include_directories(_core PRIVATE include)