fix resourceful routing paths to be acceptable to stricter Rails8 #2802
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrochkind
force-pushed
the
strict_resourceful_routing
branch
2 times, most recently
from
55dc106 to
d9d3755
Compare
can no longer mention paths that didn't apply anyway, it raises now.
jrochkind
force-pushed
the
strict_resourceful_routing
branch
from
d9d3755 to
5fe3aa5
Compare
eddierubeiz
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in routing you say
resource :something, only: [things], thethingsshould be routes that would have been created by theresourcemethod/dsl by default.If you mention something that wasn't a default route -- in Rails prior to 8, it would just be an ignored no-op. But in Rails 8 it raises, perhaps to keep you from thinking you were doing something that was just a no-op.
In prep for Rails 8 upgrade, we remove a couple times we did this -- one that was actually generated by Blacklight generator a ways back, and now results in
only: [](no default routes automatic, only ones our routing concern will add itself!), and one local. The things we removed werent' having any effect anyway, and in Rails 8 would raise.