Fix collection show-with-search customization for Rails 8 #2791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom over-ride of the "#facet" method has become out of date in Rails 8, was calling the wrong methods, raised. However on a close look -- I couldn't figure out what this override was for anyway, it looked exactly like current base implementation. Tried to see if things would work without the override at all. They appeared to? I think it has been unnecessary ever since commit 6d96dd2 in 2019 -- prior to that we were using param keys differnetly than Blacklight so needed to override method to use our different keys, but as of that commit that was no longer true and the override was prob unnecessary since then. With browser test to make sure facet "more" link was working -- that was what was broken.
eddierubeiz
approved these changes
Dec 2, 2024
Base automatically changed from
blacklight_8_update_try2_bootstrap5
to
bootstrap5
December 3, 2024 16:12
jrochkind
added a commit
that referenced
this pull request
Dec 3, 2024
Parallel to #2791 for collection controller, must do the same for featured topic controller. No longer need #facet action method override, which had become out of date in BL8."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom over-ride of the "#facet" method has become out of date in Rails 8, was calling the wrong methods, raised.
Ref #2790
However on a close look -- I couldn't figure out what this override was for anyway, it looked exactly like current base implementation. Tried to see if things would work without the override at all. They appeared to?
I think it has been unnecessary ever since commit 6d96dd2 in 2019 -- prior to that we were using param keys differnetly than Blacklight so needed to override method to use our different keys, but as of that commit that was no longer true and the override was prob unnecessary since then.
With browser test to make sure facet "more" link was working -- that was what was broken.