bluetooth.py: handle discover_devices returning bytes (instead of str) #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schodet
requested changes
Jun 26, 2022
| @@ -122,6 +122,8 @@ def find(self, host=None, name=None, **kwargs): | |||
| else: | |||
| devhost, devname = dev, None | |||
| if (host is None or devhost == host) and (name is None or devname == name): | |||
| if type(devhost) is bytes: | |||
| devhost = devhost.decode('utf8') | |||
There was a problem hiding this comment.
I think it should be done earlier, so that it can be compared with host in the if condition.
|
Is there the same problem when looking up names? Can you open an issue on pybluez so that they can fix it? |
|
Hi! Are you still interested in merging this PR, is there something I can do to help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discover_devices returns bytes instead of str (might be unique to macOS or the latest version of pybluez/lightblue?)