Add symfony 3.0 support #122
Conversation
|
The build fail is not related to this PR. |
|
I've got the same error with travis in my PR #70. |
| "doctrine/common": ">=2.3,<3.0", | ||
| "jms/di-extra-bundle": ">=1.1,<2.0" | ||
| "php": "^5.5|^7.0", | ||
| "symfony/framework-bundle": "^2.3|^3.0", |
There was a problem hiding this comment.
2.1 should still work afaics, no? any reason why we need 2.3 here?
There was a problem hiding this comment.
Symfony 2.1 and 2.2 are not supported anymore so IMO we should not continue support them too.
There was a problem hiding this comment.
If we don't need the higher version, let's keep the old 2.1 constraint.
|
@temp the tests error message really need to be improved... :/ |
|
Waiting for this pull request to be pulled. 👍 |
|
@whyte624 unfortunately I don't know how to fix the tests :-/ |
|
@Ener-Getick right now I'm using your SF3 branch. |
|
@whyte624 the |
|
+1 |
1 similar comment
|
👍 |
|
any news when this can be merged? |
| @@ -428,9 +429,25 @@ private function getCommandProcessBuilder() | |||
| $pb->add('exec'); | |||
| } | |||
|
|
|||
| // Localize the `console` command | |||
There was a problem hiding this comment.
Can we detect the console command based on how this command itself was started?
There was a problem hiding this comment.
If you check the content of $_SERVER, there should be everything you need.
There was a problem hiding this comment.
This looks much more complicated as the user can use either php console or console so we would have to parse the input.
There was a problem hiding this comment.
realpath($_SERVER['SCRIPT_FILENAME'])
// or
realpath($_SERVER['argv'][0])should do the trick, whether the php executable is mentioned or not.
This looks safer than expecting to find a single file called console somewhere under the root dir - which is a convention that not all projects might follow.
There was a problem hiding this comment.
@nclavaud could you send a PR on my repo ?
There was a problem hiding this comment.
@Ener-Getick @schmittjoh what do you think of https://github.com/Ener-Getick/JMSJobQueueBundle/pull/3 ?
There was a problem hiding this comment.
@nclavaud i don't think it will work when using phpunit :/
|
@Ener-Getick |
|
done @ruslan-polutsygan |
|
May I ask when approximately is this going to be merged into the master please? |
|
+1 |
|
Any news on this? What are we waiting for? |
|
It looks like repo owner is not reviewing issues and pull requests anymore. |
|
@stephanvierkant @dextervip you can still try to send him a message on twitter, he may have too many notifications ;-) |
|
@Ener-Getick Are you using this pull request in your production env with sf3? |
|
@dextervip no i don't, but it seems that others do (my repo has been forked several times and some issues have been reported). |
|
There is one test failing in travis build, Any ideas? I guess It should be fixed before we hit up |
|
@dextervip in fact this is already failing in the current state and the test pass on my machine so i have no idea from what it comes. |
|
@Ener-Getick Yes, just noticed it. Maybe we should ask to be created a 1.x branch to maintain legacy bundle support and use master to develop new sf3 support, new BC features and release 2.x versions. What do you think guys? |
|
@dextervip this PR is fully bc so i don't think we need to release a new major version. |
|
Eagerly waiting for this to get merged! 👍 |
|
Still waiting.. 😉 |
|
Is there any news about this? |
|
@lordjancso @dmkuznetsov @nullziu If you want a workaround while this request is not accepted, I have been using @Ener-Getick's fork since June 22 without any problem. |
|
It looks like @schmittjoh added sf 3 support in the latest commits, so let's close this pr :) |
This PR adds symfony 3.0 support and removes the usage of the deprecated
FlattenExceptionclass.Fix #115, #121, #116, #73