Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for v2.16.1 #2709

Open
wants to merge 31 commits into
base: origin-v2.16.1-1733754652
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
commit patch 27123509
  • Loading branch information
turly221 committed Dec 9, 2024
commit 2ac1780f9f7448aad4645d4d050c2dd55e5f4678
8 changes: 8 additions & 0 deletions submodule-config.c
Original file line number Diff line number Diff line change
@@ -352,6 +352,12 @@ static void warn_multiple_config(const unsigned char *treeish_name,
commit_string, name, option);
}

static void warn_command_line_option(const char *var, const char *value)
{
warning(_("ignoring '%s' which may be interpreted as"
" a command-line option: %s"), var, value);
}

struct parse_config_parameter {
struct submodule_cache *cache;
const unsigned char *treeish_name;
@@ -417,6 +423,8 @@ static int parse_config(const char *var, const char *value, void *data)
} else if (!strcmp(item.buf, "url")) {
if (!value) {
ret = config_error_nonbool(var);
} else if (looks_like_command_line_option(value)) {
warn_command_line_option(var, value);
} else if (!me->overwrite && submodule->url) {
warn_multiple_config(me->treeish_name, submodule->name,
"url");
Loading