Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/SK-1217 | Add client settings to client v2 #754

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Feature/SK-1217 | Add client settings to client v2 #754

merged 1 commit into from
Nov 22, 2024

Conversation

viktorvaladi
Copy link
Contributor

Adds client settings to client v2 so that the UDF code is functional.

@github-actions github-actions bot added minor feature New feature or request labels Nov 18, 2024
Wrede
Wrede approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@Wrede Wrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add @benjaminastrand and @niklastheman as reviewer also I want 1 approval from them.

@viktorvaladi viktorvaladi changed the title Feature/SK-1217 | Add client settings to client v2 Feature/SK-1220 | Add client settings to client v2 Nov 19, 2024
@viktorvaladi viktorvaladi changed the title Feature/SK-1220 | Add client settings to client v2 Feature/SK-1217 | Add client settings to client v2 Nov 19, 2024
benjaminastrand
benjaminastrand requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@benjaminastrand benjaminastrand left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since client_options is saved inside _process_training_request in client_v2.py, it will only be saved if the user chooses to start the client through fedn client start.

I suggest saving the client_options in update_local_model in fedn_client.py instead.

@viktorvaladi
Copy link
Contributor Author

Since client_options is saved inside _process_training_request in client_v2.py, it will only be saved if the user chooses to start the client through fedn client start.

I suggest saving the client_options in update_local_model in fedn_client.py instead.

As discussed on discord, its good to have it as it is in the PR? So for the on_train() function it would be the client_settings parameter added which defaults to an empty dict if its not used?

@viktorvaladi viktorvaladi merged commit aa0ce51 into master Nov 22, 2024
22 checks passed
@viktorvaladi viktorvaladi deleted the feature/SK-1217 branch November 22, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminastrand benjaminastrand benjaminastrand approved these changes

@Wrede Wrede Wrede approved these changes

@niklastheman niklastheman Awaiting requested review from niklastheman

Assignees
No one assigned
Labels
feature New feature or request minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viktorvaladi @Wrede @benjaminastrand