Bug/SK-931 | --preferred-combiner should not be boolean #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sowmyasris
changed the title
Wrede
requested changes
Aug 12, 2024
fedn/network/clients/connect.py
Outdated
| @@ -38,7 +38,7 @@ class ConnectorClient: | |||
| :param force_ssl: True if https is used, False if http | |||
| :type force_ssl: bool | |||
| :param verify: True if certificate is verified, False if not | |||
| :type verify: bool | |||
| :type verify: str | |||
There was a problem hiding this comment.
Because this param is for preferred-combiner which will be the name of the combiner, so verifying if it is string.
sowmyasris
changed the title
This reverts commit f75159c.
Wrede
changed the title
Wrede
approved these changes
Aug 16, 2024
| @@ -47,7 +47,7 @@ | |||
| "secure": False, | |||
| "preshared_cert": False, | |||
| "verify": False, | |||
| "preferred_combiner": False, | |||
| "combiner": "combiner", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed --preferred-combiner flag in run_cmd and client_cmd to --combiner
Type change from boolean to string