Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Log message by default #7052

Merged
merged 1 commit into from
Dec 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
bugfix: Log message by default
Turns out it was actually set in a totally different place, which I haven't realized.
tgodzik committed Dec 20, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 887c8e31d5ae714e5e480f20a8118774335c6442
Original file line number Diff line number Diff line change
@@ -18,6 +18,6 @@ object StatusBarConfig {
)
def bspDefault =
new StatusBarConfig(
System.getProperty("metals.bsp-status-bar", "show-message")
System.getProperty("metals.bsp-status-bar", "log-message")
)
}
Original file line number Diff line number Diff line change
@@ -7,6 +7,7 @@ import scala.meta.internal.metals.Icons
import scala.meta.internal.metals.Messages
import scala.meta.internal.metals.MetalsEnrichments._
import scala.meta.internal.metals.MetalsServerConfig
import scala.meta.internal.metals.StatusBarConfig

import bill.Bill
import ch.epfl.scala.bsp4j.BuildTargetIdentifier
@@ -18,6 +19,7 @@ class ServerLivenessMonitorLspSuite extends BaseLspSuite("liveness-monitor") {
MetalsServerConfig.default.copy(
metalsToIdleTime = Duration("3m"),
pingInterval = pingInterval,
bspStatusBar = StatusBarConfig.showMessage,
)

test("handle-not-responding-server") {